- 
                Notifications
    You must be signed in to change notification settings 
- Fork 5.5k
Fix casing #32483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix casing #32483
Conversation
| Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. | 
| Generated ApiView
 | 
| API change check APIView has identified API level changes in this PR and created following API reviews. | 
This reverts commit d0674aa.
        
          
                ...atafactory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json
          
            Show resolved
            Hide resolved
        
      | "LakeHouseTableDataset": { | ||
| "x-ms-discriminator-value": "LakeHouseTable", | ||
| "description": "Microsoft Fabric LakeHouse Table.", | ||
| "x-ms-discriminator-value": "LakehouseTable", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JeffreyRichter @mikeharder I feel like this is an api layer breaking here, but it's not getting detected correctly. because if customers want to pass an object for LakeHouseTableDataset, they will have to change the discriminator property type's value from "LakeHouseTable" to "LakehouseTable". Should we enhance our tooling so that we don't miss cases like this?
but as @JaylenZ8 confirmed offline, since service backend is backward compatible for this, and it can still recognize "LakeHouseTable" I guess it's probably okay for this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@qiaozha: Please open an issue at https://github.com/Azure/openapi-diff/issues to suggest a bug fix or feature request for the breaking changes detector.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, issue created here Azure/openapi-diff#350
* Fix casing * Revert "Fix casing" This reverts commit d0674aa. * Fix * Update sdk-suppressions.yaml --------- Co-authored-by: kazrael2119 <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.