Skip to content

Fix casing #32483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Fix casing #32483

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0674aa
Fix casing
JaylenZ8 Feb 6, 2025
b96db6d
Revert "Fix casing"
JaylenZ8 Feb 7, 2025
bde31a5
Fix
JaylenZ8 Feb 7, 2025
5d77c3d
Update sdk-suppressions.yaml
kazrael2119 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions ...factory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@
]
},
"LakeHouseLocation": {
"description": "The location of Microsoft Fabric LakeHouse Files dataset.",
"description": "The location of Microsoft Fabric Lakehouse Files dataset.",
"type": "object",
"allOf": [
{
Expand Down Expand Up @@ -3712,8 +3712,8 @@
}
},
"LakeHouseTableDataset": {
"x-ms-discriminator-value": "LakeHouseTable",
"description": "Microsoft Fabric LakeHouse Table.",
"x-ms-discriminator-value": "LakehouseTable",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffreyRichter @mikeharder I feel like this is an api layer breaking here, but it's not getting detected correctly. because if customers want to pass an object for LakeHouseTableDataset, they will have to change the discriminator property type's value from "LakeHouseTable" to "LakehouseTable". Should we enhance our tooling so that we don't miss cases like this?

but as @JaylenZ8 confirmed offline, since service backend is backward compatible for this, and it can still recognize "LakeHouseTable" I guess it's probably okay for this one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qiaozha: Please open an issue at https://github.com/Azure/openapi-diff/issues to suggest a bug fix or feature request for the breaking changes detector.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, issue created here Azure/openapi-diff#350

"description": "Microsoft Fabric Lakehouse Table.",
"type": "object",
"allOf": [
{
Expand All @@ -3722,25 +3722,25 @@
],
"properties": {
"typeProperties": {
"description": "Microsoft Fabric LakeHouse Table dataset properties.",
"description": "Microsoft Fabric Lakehouse Table dataset properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/LakeHouseTableDatasetTypeProperties"
}
}
},
"LakeHouseTableDatasetTypeProperties": {
"description": "Microsoft Fabric LakeHouse Table dataset properties.",
"description": "Microsoft Fabric Lakehouse Table dataset properties.",
"type": "object",
"properties": {
"schema": {
"type": "object",
"x-ms-format": "dfe-string",
"description": "The schema name of Microsoft Fabric LakeHouse Table. Type: string (or Expression with resultType string)."
"description": "The schema name of Microsoft Fabric Lakehouse Table. Type: string (or Expression with resultType string)."
},
"table": {
"type": "object",
"x-ms-format": "dfe-string",
"description": "The name of Microsoft Fabric LakeHouse Table. Type: string (or Expression with resultType string)."
"description": "The name of Microsoft Fabric Lakehouse Table. Type: string (or Expression with resultType string)."
}
}
},
Expand Down
14 changes: 7 additions & 7 deletions ...y/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/LinkedService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8470,8 +8470,8 @@
]
},
"LakeHouseLinkedService": {
"x-ms-discriminator-value": "LakeHouse",
"description": "Microsoft Fabric LakeHouse linked service.",
"x-ms-discriminator-value": "Lakehouse",
"description": "Microsoft Fabric Lakehouse linked service.",
"type": "object",
"allOf": [
{
Expand All @@ -8480,7 +8480,7 @@
],
"properties": {
"typeProperties": {
"description": "Microsoft Fabric LakeHouse linked service properties.",
"description": "Microsoft Fabric Lakehouse linked service properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/LakeHouseLinkedServiceTypeProperties"
}
Expand All @@ -8490,7 +8490,7 @@
]
},
"LakeHouseLinkedServiceTypeProperties": {
"description": "Microsoft Fabric LakeHouse linked service properties.",
"description": "Microsoft Fabric Lakehouse linked service properties.",
"type": "object",
"properties": {
"workspaceId": {
Expand All @@ -8501,15 +8501,15 @@
"artifactId": {
"type": "object",
"x-ms-format": "dfe-string",
"description": "The ID of Microsoft Fabric LakeHouse artifact. Type: string (or Expression with resultType string)."
"description": "The ID of Microsoft Fabric Lakehouse artifact. Type: string (or Expression with resultType string)."
},
"servicePrincipalId": {
"type": "object",
"x-ms-format": "dfe-string",
"description": "The ID of the application used to authenticate against Microsoft Fabric LakeHouse. Type: string (or Expression with resultType string)."
"description": "The ID of the application used to authenticate against Microsoft Fabric Lakehouse. Type: string (or Expression with resultType string)."
},
"servicePrincipalKey": {
"description": "The Key of the application used to authenticate against Microsoft Fabric LakeHouse.",
"description": "The Key of the application used to authenticate against Microsoft Fabric Lakehouse.",
"$ref": "../datafactory.json#/definitions/SecretBase"
},
"tenant": {
Expand Down
14 changes: 7 additions & 7 deletions ...actory/resource-manager/Microsoft.DataFactory/stable/2018-06-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,7 @@
}
},
"LakeHouseReadSettings": {
"description": "Microsoft Fabric LakeHouse Files read settings.",
"description": "Microsoft Fabric Lakehouse Files read settings.",
"type": "object",
"allOf": [
{
Expand All @@ -1109,12 +1109,12 @@
"wildcardFolderPath": {
"type": "object",
"x-ms-format": "dfe-string",
"description": "Microsoft Fabric LakeHouse Files wildcardFolderPath. Type: string (or Expression with resultType string)."
"description": "Microsoft Fabric Lakehouse Files wildcardFolderPath. Type: string (or Expression with resultType string)."
},
"wildcardFileName": {
"type": "object",
"x-ms-format": "dfe-string",
"description": "Microsoft Fabric LakeHouse Files wildcardFileName. Type: string (or Expression with resultType string)."
"description": "Microsoft Fabric Lakehouse Files wildcardFileName. Type: string (or Expression with resultType string)."
},
"fileListPath": {
"type": "object",
Expand Down Expand Up @@ -1257,7 +1257,7 @@
]
},
"LakeHouseWriteSettings": {
"description": "Microsoft Fabric LakeHouse Files write settings.",
"description": "Microsoft Fabric Lakehouse Files write settings.",
"type": "object",
"allOf": [
{
Expand Down Expand Up @@ -4300,7 +4300,7 @@
}
},
"LakeHouseTableSource": {
"description": "A copy activity source for Microsoft Fabric LakeHouse Table.",
"description": "A copy activity source for Microsoft Fabric Lakehouse Table.",
"type": "object",
"allOf": [
{
Expand Down Expand Up @@ -5959,7 +5959,7 @@
}
},
"LakeHouseTableSink": {
"description": "A copy activity for Microsoft Fabric LakeHouse Table sink.",
"description": "A copy activity for Microsoft Fabric Lakehouse Table sink.",
"type": "object",
"allOf": [
{
Expand All @@ -5970,7 +5970,7 @@
"tableActionOption": {
"type": "object",
"x-ms-format": "dfe-string",
"description": "The type of table action for LakeHouse Table sink. Possible values include: \"None\", \"Append\", \"Overwrite\"."
"description": "The type of table action for Lakehouse Table sink. Possible values include: \"None\", \"Append\", \"Overwrite\"."
},
"partitionOption": {
"type": "object",
Expand Down
14 changes: 7 additions & 7 deletions ...ification/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Dataset.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
]
},
"LakeHouseLocation": {
"description": "The location of Microsoft Fabric LakeHouse Files dataset.",
"description": "The location of Microsoft Fabric Lakehouse Files dataset.",
"type": "object",
"allOf": [
{
Expand Down Expand Up @@ -3545,8 +3545,8 @@
}
},
"LakeHouseTableDataset": {
"x-ms-discriminator-value": "LakeHouseTable",
"description": "Microsoft Fabric LakeHouse Table.",
"x-ms-discriminator-value": "LakehouseTable",
"description": "Microsoft Fabric Lakehouse Table.",
"type": "object",
"allOf": [
{
Expand All @@ -3555,23 +3555,23 @@
],
"properties": {
"typeProperties": {
"description": "Microsoft Fabric LakeHouse Table dataset properties.",
"description": "Microsoft Fabric Lakehouse Table dataset properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/LakeHouseTableDatasetTypeProperties"
}
}
},
"LakeHouseTableDatasetTypeProperties": {
"description": "Microsoft Fabric LakeHouse Table dataset properties.",
"description": "Microsoft Fabric Lakehouse Table dataset properties.",
"type": "object",
"properties": {
"schema": {
"type": "object",
"description": "The schema name of Microsoft Fabric LakeHouse Table. Type: string (or Expression with resultType string)."
"description": "The schema name of Microsoft Fabric Lakehouse Table. Type: string (or Expression with resultType string)."
},
"table": {
"type": "object",
"description": "The name of Microsoft Fabric LakeHouse Table. Type: string (or Expression with resultType string)."
"description": "The name of Microsoft Fabric Lakehouse Table. Type: string (or Expression with resultType string)."
}
}
},
Expand Down
14 changes: 7 additions & 7 deletions ...ion/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/LinkedService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7730,8 +7730,8 @@
]
},
"LakeHouseLinkedService": {
"x-ms-discriminator-value": "LakeHouse",
"description": "Microsoft Fabric LakeHouse linked service.",
"x-ms-discriminator-value": "Lakehouse",
"description": "Microsoft Fabric Lakehouse linked service.",
"type": "object",
"allOf": [
{
Expand All @@ -7740,7 +7740,7 @@
],
"properties": {
"typeProperties": {
"description": "Microsoft Fabric LakeHouse linked service properties.",
"description": "Microsoft Fabric Lakehouse linked service properties.",
"x-ms-client-flatten": true,
"$ref": "#/definitions/LakeHouseLinkedServiceTypeProperties"
}
Expand All @@ -7750,7 +7750,7 @@
]
},
"LakeHouseLinkedServiceTypeProperties": {
"description": "Microsoft Fabric LakeHouse linked service properties.",
"description": "Microsoft Fabric Lakehouse linked service properties.",
"type": "object",
"properties": {
"workspaceId": {
Expand All @@ -7759,14 +7759,14 @@
},
"artifactId": {
"type": "object",
"description": "The ID of Microsoft Fabric LakeHouse artifact. Type: string (or Expression with resultType string)."
"description": "The ID of Microsoft Fabric Lakehouse artifact. Type: string (or Expression with resultType string)."
},
"servicePrincipalId": {
"type": "object",
"description": "The ID of the application used to authenticate against Microsoft Fabric LakeHouse. Type: string (or Expression with resultType string)."
"description": "The ID of the application used to authenticate against Microsoft Fabric Lakehouse. Type: string (or Expression with resultType string)."
},
"servicePrincipalKey": {
"description": "The Key of the application used to authenticate against Microsoft Fabric LakeHouse.",
"description": "The Key of the application used to authenticate against Microsoft Fabric Lakehouse.",
"$ref": "../artifacts.json#/definitions/SecretBase"
},
"tenant": {
Expand Down
14 changes: 7 additions & 7 deletions ...fication/synapse/data-plane/Microsoft.Synapse/stable/2020-12-01/entityTypes/Pipeline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,7 +826,7 @@
}
},
"LakeHouseReadSettings": {
"description": "Microsoft Fabric LakeHouse Files read settings.",
"description": "Microsoft Fabric Lakehouse Files read settings.",
"type": "object",
"allOf": [
{
Expand All @@ -840,11 +840,11 @@
},
"wildcardFolderPath": {
"type": "object",
"description": "Microsoft Fabric LakeHouse Files wildcardFolderPath. Type: string (or Expression with resultType string)."
"description": "Microsoft Fabric Lakehouse Files wildcardFolderPath. Type: string (or Expression with resultType string)."
},
"wildcardFileName": {
"type": "object",
"description": "Microsoft Fabric LakeHouse Files wildcardFileName. Type: string (or Expression with resultType string)."
"description": "Microsoft Fabric Lakehouse Files wildcardFileName. Type: string (or Expression with resultType string)."
},
"fileListPath": {
"type": "object",
Expand Down Expand Up @@ -971,7 +971,7 @@
]
},
"LakeHouseWriteSettings": {
"description": "Microsoft Fabric LakeHouse Files write settings.",
"description": "Microsoft Fabric Lakehouse Files write settings.",
"type": "object",
"allOf": [
{
Expand Down Expand Up @@ -3810,7 +3810,7 @@
}
},
"LakeHouseTableSource": {
"description": "A copy activity source for Microsoft Fabric LakeHouse Table.",
"description": "A copy activity source for Microsoft Fabric Lakehouse Table.",
"type": "object",
"allOf": [
{
Expand Down Expand Up @@ -5186,7 +5186,7 @@
}
},
"LakeHouseTableSink": {
"description": "A copy activity for Microsoft Fabric LakeHouse Table sink.",
"description": "A copy activity for Microsoft Fabric Lakehouse Table sink.",
"type": "object",
"allOf": [
{
Expand All @@ -5196,7 +5196,7 @@
"properties": {
"tableActionOption": {
"type": "object",
"description": "The type of table action for LakeHouse Table sink. Possible values include: \"None\", \"Append\", \"Overwrite\"."
"description": "The type of table action for Lakehouse Table sink. Possible values include: \"None\", \"Append\", \"Overwrite\"."
},
"partitionOption": {
"type": "object",
Expand Down