Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Mar 12, 2020

Description

Reopen on new storage preview branch as #11177 is closed.

There are no syntax changes, so no review docs raised in https://github.com/Azure/azure-powershell-cmdlet-review-pr

But I have raised a design doc, Erich has helped to review it. https://microsoft.sharepoint.com/:w:/t/XClientShanghai/EVNIP90Ijg1KsZT0VFEA6pgB33mx1WbdypGOXWTkLvgTHA?e=7SjutU

For Oauth:

For the oauth token, I implement my own class "AzureSessionCredential", I can switch to the common one provided by Powershell team (prototype: https://github.com/erich-wang/azure-powershell/commit/2b3791333) when it's merged to master.

Commits:

This PR include many changes from master, which is not already on storage branch.
Only the last commit is for this feature change.
When #11161 is merged, should only left the last commit.

For test:

I have tested it works on

  • Powershell 5.1
  • Powershell 6.2.4

With authentication:

  1. Key
  2. SAS
  3. Oauth
  4. Anonymous

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@isra-fel isra-fel self-assigned this Mar 13, 2020
@isra-fel
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@isra-fel
Copy link
Member

isra-fel commented Mar 13, 2020

@erich-wang Hi Erich, could you review this PR cause it's related to track 2 SDK? Thanks

BTW @blueww I'm not sure but it could be that the static analysis error was caused by wrong format of L59-60 in https://github.com/Azure/azure-powershell/blob/Az.Storage-preview/tools/StaticAnalysis/Exceptions/Az.Storage/SignatureIssues.csv#L59

@isra-fel isra-fel assigned erich-wang and unassigned isra-fel Mar 13, 2020
@blueww
Copy link
Member Author

blueww commented Mar 13, 2020

@isra-fel

@erich-wang has a fix for the static analysis issue in https://github.com/Azure/azure-powershell/tree/erich/storage-track2-analysis
But the fix is still not finalized, and still need discuss with Mark.

@blueww
Copy link
Member Author

blueww commented Mar 25, 2020

Close as the change is included in #11402

@blueww blueww closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants