Skip to content

Conversation

@blueww
Copy link
Member

@blueww blueww commented Feb 24, 2020

Description

For Design:

There are no syntax changes, so no review docs raised in https://github.com/Azure/azure-powershell-cmdlet-review-pr

But I have raised a design doc, Erich has helped to review it. https://microsoft.sharepoint.com/:w:/t/XClientShanghai/EVNIP90Ijg1KsZT0VFEA6pgB33mx1WbdypGOXWTkLvgTHA?e=7SjutU

For Oauth:

For the oauth token, I implement my own class "AzureSessionCredential", I can switch to the common one provided by Powershell team (prototype: https://github.com/erich-wang/azure-powershell/commit/2b3791333) when it's merged to master.

Commits:

This PR include many changes from master, which is not already on storage branch.
Only the last commit is for this feature change.
When #11161 is merged, should only left the last commit.

For test:

I have tested it works on

  • Powershell 5.1
  • Powershell 6.2.4

With authentication:

  1. Key
  2. SAS
  3. Oauth
  4. Anonymous

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

@erich-wang
Copy link
Member

/azp run

@azure-pipelines
Copy link
Contributor

Pull request contains merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants