Skip to content

Edit FunctionMetadataResponses message to be more descriptive #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
satvu merged 3 commits into from
Oct 20, 2021
Merged

Edit FunctionMetadataResponses message to be more descriptive #59

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfb70aa
add suggested changes
satvu Oct 14, 2021
40346d6
typo fix
satvu Oct 14, 2021
155c7e2
clarifying that function load request resultsare returned
satvu Oct 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/proto/FunctionRpc.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,10 +284,10 @@ message FunctionsMetadataRequest {
// Worker sends function metadata back to host
message FunctionMetadataResponses {
// list of function indexing responses
repeated FunctionLoadRequest results = 1;
repeated FunctionLoadRequest function_load_requests_results = 1;

// status of overall metadata request
StatusResult overall_status = 2;
StatusResult result = 2;
Copy link
Member Author

@satvu satvu Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency w/ other messages - StatusResult type is generally returned in "result".

}

// Host requests worker to invoke a Function
Expand Down