Edit FunctionMetadataResponses message to be more descriptive #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satvu
commented
Oct 14, 2021
src/proto/FunctionRpc.proto
Outdated
| message FunctionMetadataResponses { | ||
| // list of function indexing responses | ||
| repeated FunctionLoadRequest results = 1; | ||
| repeated FunctionLoadRequest function_load_requests = 1; |
Member
Author
There was a problem hiding this comment.
i think this is the simplest description/name. It's clearer than "results" and there is no confusion on the meaning b/c almost all messages with a "result" field refer to the StatusResult.
Member
There was a problem hiding this comment.
function_load_requests_results to be more clear, to ensure this is the result of function load on language worker
satvu
commented
Oct 14, 2021
|
|
||
| // status of overall metadata request | ||
| StatusResult overall_status = 2; | ||
| StatusResult result = 2; |
Member
Author
There was a problem hiding this comment.
Consistency w/ other messages - StatusResult type is generally returned in "result".
satvu
requested review from
fabiocav,
pragnagopa,
soninaren and
surgupta-msft
5 tasks
pragnagopa
approved these changes
Oct 15, 2021
7 tasks
kshyju
approved these changes
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added changes to the FunctionMetadataResponses message to be more consistent with the design of other messages and to be more descriptive.