vm live test: allow more valid power states on vmss test verifications #2564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yugangw-msft
changed the title
Codecov Report
@@ Coverage Diff @@
## master #2564 +/- ##
=======================================
Coverage 72.29% 72.29%
=======================================
Files 363 363
Lines 19832 19832
Branches 2923 2923
=======================================
Hits 14338 14338
Misses 4580 4580
Partials 914 914Continue to review full report at Codecov.
|
troydai
approved these changes
Mar 21, 2017
Contributor
troydai
left a comment
troydai
left a comment
There was a problem hiding this comment.
Besides the comments, I approve this pull request.
Contributor
There was a problem hiding this comment.
The following definition can make the usage easier:
def _check_vms_power_state(self, *args):
The client will look like:
self._check_vms_power_state('PowerState/running', 'PowerState/starting')
This save the extra step to create a list.
Besides, I don't think the method has to initialize with _. It is meaningless given this is merely a test case.
thegalah
pushed a commit
to thegalah/azure-cli
that referenced
this pull request
Mar 21, 2017
* Azure/master: (478 commits) vm live test: allow more valid power states on vmss test verifications (Azure#2564) rbac:catch more graph error (Azure#2567) appservice: support to create plan when create a webapp (Azure#2550) Update storage tests (Azure#2556) Change PEP8 check filter from whitelist to blacklist (Azure#2557) Add scenario tests documentation (Azure#2555) [ACS] Adding support for configuring a default ACS cluster (Azure#2554) [ACS] Provide a short name alias for the orchestrator type flag (Azure#2553) Sql Import/Export CLI commands and test (Azure#2538) Fix format bug. (Azure#2549) [VM/VMSS] Improved disk caching support (Azure#2522) VM/VMSS: incorporate credentials validation logic used by portal (Azure#2537) Script that creates packaged releases package archive (Azure#2508) Adding alias for defaults flag (Azure#2540) Add wait commands and --no-wait support (Azure#2524) choice list outside of named arguments (Azure#2521) Fixed test failure in test_sql_db_mgmt. (Azure#2530) core: support login using service principal with a cert (Azure#2457) Add note about being in preview (Azure#2512) vm:fix distro check mechanism used by disk encryption (Azure#2511) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.