Skip to content

[VM/VMSS] Improved disk caching support #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tjprescott merged 2 commits into from
Mar 17, 2017
Merged

[VM/VMSS] Improved disk caching support #2522

tjprescott merged 2 commits into from
Mar 17, 2017

Conversation

@tjprescott
Copy link
Member

@tjprescott tjprescott commented Mar 15, 2017 •
edited
Loading

Closes #2497.

  • VMSS create no longer adds template variables regarding storage account unless storage accounts will be created. While these didn't do anything before if storage accounts weren't created, it was confusing when you would view the template.
  • Adds an alias to vm/vmss create for OS disk caching. The existing --storage-caching exists alongside --os-caching. The intent is that --storage-caching will be deprecated and removed in the future. (Issue 'vm/vmss create': deprecate and remove --storage-caching #2523)
  • Adds --data-caching to vm/vmss create which is the caching type used for data disks.
  • Adds --caching to vm disk/vmss disk/vm unmanaged-disk attach command.
  • Reflects on the SDK's CachingType object to expose all caching types (including None). Due to a bug in the Swagger (OS Disk Caching for VM/VMSS OSProfile should not support None azure-rest-api-specs#1044), I manually omit "None" from the list of OS Disk caching types.
  • Removes the hard coded default values for caching and allows the service to apply defaults if not specified. For VMSS, which defaults to a supposedly invalid caching value of "None", I set the default to "ReadWrite" to match VM create.

@tjprescott tjprescott added the Compute az vm/vmss/image/disk/snapshot label Mar 15, 2017
@tjprescott tjprescott added this to the Sprint 14 milestone Mar 15, 2017
@tjprescott tjprescott requested a review from yugangw-msft March 15, 2017 21:25
@tjprescott tjprescott mentioned this pull request Mar 15, 2017
Closed
@codecov-io
Copy link

codecov-io commented Mar 15, 2017 •
edited
Loading

Codecov Report

Merging #2522 into master will increase coverage by <.01%.
The diff coverage is 89.47%.

@@            Coverage Diff            @@
##           master   #2522      +/-   ##
=========================================
+ Coverage    72.1%   72.1%   +<.01%     
=========================================
  Files         362     362              
  Lines       19790   19791       +1     
  Branches     2920    2920              
=========================================
+ Hits        14269   14270       +1     
  Misses       4600    4600              
  Partials      921     921
Impacted Files Coverage Δ
.../azure/cli/command_modules/vm/_template_builder.py 80.95% <0%> (ø) ✅
...ure-cli-vm/azure/cli/command_modules/vm/_params.py 96.05% <100%> (+0.01%) ✅
...zure-cli-vm/azure/cli/command_modules/vm/custom.py 73.82% <100%> (ø) ✅
...cli-vm/azure/cli/command_modules/vm/_validators.py 72.17% <75%> (ø) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a31807...79cd649. Read the comment docs.

yugangw-msft
yugangw-msft reviewed Mar 16, 2017
View reviewed changes
Copy link
Contributor

@yugangw-msft yugangw-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to overall. Left a few suggestions

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_template_builder.py Outdated
Copy link
Contributor

@yugangw-msft yugangw-msft Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest exposing --os-disk-caching and --data-disk-caching. Were this PR out last month, these short names look pretty good; but now with customdata and secret support, it is necessary to be a bit complete to avoid potential confusions.

Copy link
Member Author

@tjprescott tjprescott Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to keep this short. It is consistent with --os-type (which refers to a disk) and is in the storage argument group, so I think it's pretty clear.

Copy link
Contributor

@yugangw-msft yugangw-msft Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With help it will be clear, but there is also a scenario that when you read existing commands, the meaning should be clear w/o referring to help.
There are lots and lots of caching mechanisms in the whole stack from CPU cache to the web page cache at the top, so when I talk about cache, I have to be very specific on the term and context, otherwise people would not understand. This is why I am not quite into the argument naming of --os-caching, and --data-cache, because they could mean lots of different things.
However, I would not let my own experience/knowledge to determine the naming for wide audience. So /cc: @gbowerman @gatneil, if they are fine with this short naming, I will be fine too.

Copy link

@gbowerman gbowerman Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although longer, we probably need 'disk' in the names for clarity, e.g. --os-disk-caching, --data-disk-caching, or --os-disk-cache, --data-disk-cache.

Copy link
Member Author

@tjprescott tjprescott Mar 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_template_builder.py Outdated
Copy link
Contributor

@yugangw-msft yugangw-msft Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please set the caching on data disks coming with the managed image itself. The code is about 10 lines above

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_template_builder.py Outdated
Copy link
Contributor

@yugangw-msft yugangw-msft Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are here, please fix it to be [StorageProfile.ManagedPirImage, StorageProfile.ManagedCustomImage]

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_validators.py Outdated
Copy link
Contributor

@yugangw-msft yugangw-msft Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think for any unmanaged storage profiles, the data_caching would not apply, hence we should error

src/command_modules/azure-cli-vm/azure/cli/command_modules/vm/_params.py Outdated
Copy link
Contributor

@yugangw-msft yugangw-msft Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is we should set Read/Write to OS Disk for VMSS, as the service default as None is not favorable

Copy link
Member Author

@tjprescott tjprescott Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the latest email says it should be whatever VM is, which is ReadWrite.

Copy link
Member Author

@tjprescott tjprescott Mar 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, I suppressed "None" from the enum for OS caching.

@tjprescott
Copy link
Member Author

tjprescott commented Mar 17, 2017

@yugangw-msft changes made

@tjprescott tjprescott merged commit b9c09d2 into Azure:master Mar 17, 2017
@tjprescott tjprescott deleted the SupportBigOlVMSS branch March 17, 2017 21:30
thegalah pushed a commit to thegalah/azure-cli that referenced this pull request Mar 21, 2017
Merge remote-tracking branch 'Azure/master'
184224f 
* Azure/master: (478 commits)
  vm live test: allow more valid power states on vmss test verifications (Azure#2564)
  rbac:catch more graph error (Azure#2567)
  appservice: support to create plan when create a webapp (Azure#2550)
  Update storage tests (Azure#2556)
  Change PEP8 check filter from whitelist to blacklist (Azure#2557)
  Add scenario tests documentation (Azure#2555)
  [ACS] Adding support for configuring a default ACS cluster (Azure#2554)
  [ACS] Provide a short name alias for the orchestrator type flag (Azure#2553)
  Sql Import/Export CLI commands and test (Azure#2538)
  Fix format bug. (Azure#2549)
  [VM/VMSS] Improved disk caching support (Azure#2522)
  VM/VMSS: incorporate credentials validation logic used by portal (Azure#2537)
  Script that creates packaged releases package archive (Azure#2508)
  Adding alias for defaults flag (Azure#2540)
  Add wait commands and --no-wait support (Azure#2524)
  choice list outside of named arguments (Azure#2521)
  Fixed test failure in test_sql_db_mgmt. (Azure#2530)
  core: support login using service principal with a cert (Azure#2457)
  Add note about being in preview (Azure#2512)
  vm:fix distro check mechanism used by disk encryption (Azure#2511)
  ...
@haroldrandom haroldrandom added cla-not-required Compute az vm/vmss/image/disk/snapshot labels Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gbowerman gbowerman gbowerman left review comments

@yugangw-msft yugangw-msft yugangw-msft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-not-required Compute az vm/vmss/image/disk/snapshot

Projects

None yet

Milestone

Sprint 14

Development

Successfully merging this pull request may close these issues.

6 participants

@tjprescott @codecov-io @gbowerman @yugangw-msft @msftclas @haroldrandom