Config Settings and Documentation #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cfg-documentation-vy
User guide documentation updates
i-am-sijia
requested changes
Jan 3, 2024
Contributor
i-am-sijia
left a comment
i-am-sijia
left a comment
There was a problem hiding this comment.
Some of my initial comments. Still need to go through the implementation changes
i-am-sijia
reviewed
Jan 4, 2024
Contributor
i-am-sijia
left a comment
i-am-sijia
left a comment
There was a problem hiding this comment.
Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
i-am-sijia
approved these changes
Jan 31, 2024
# Conflicts: # activitysim/abm/models/util/tour_frequency.py # activitysim/examples/production_semcog/configs/logging.yaml # conda-environments/activitysim-dev-base.yml # conda-environments/activitysim-dev.yml # conda-environments/docbuild.yml # docs/models.rst
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress: