Skip to content

Conversation

@marcelmamula
Copy link

Disclaimer

This is breaking change as all variables were redesigned without backwards compatibility.
Previously used variables were not adhering to best practices and failed linting.

This activity is part of major redesign of all roles in preparation for 1.0 release. More details in #45

Changes

This role was completely broken down and rebuilt from ground up to follow Ansible best practices, Ansible 2.20 linting and Project guidelines.

  • Majority of variables removed and replaced with much more powerful definition variable
  • Assert for all definitions and variables added
  • Validation of all definitions against target host
  • Replicated whole functionality of community.sap_libs.sap_system_facts into native Ansible code to remove dependency.
    • It can still be used with new variable.
  • Code was refactored to adhere to best practices and all changes in ansible-core 2.19 and 2.20

Tests

This PR was tested on SLES for SAP Applications 15 SP6 and 16 targeting hosts with latest SAP BW4HANA installed.

FYI
@crweller
@nbttmbrg
@sean-freeman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant