sap_control: Complete redesign and rework #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer
This is breaking change as all variables were redesigned without backwards compatibility.
Previously used variables were not adhering to best practices and failed linting.
This activity is part of major redesign of all roles in preparation for 1.0 release. More details in #45
Changes
This role was completely broken down and rebuilt from ground up to follow Ansible best practices, Ansible 2.20 linting and Project guidelines.
community.sap_libs.sap_system_factsinto native Ansible code to remove dependency.Tests
This PR was tested on SLES for SAP Applications 15 SP6 and 16 targeting hosts with latest SAP BW4HANA installed.
FYI
@crweller
@nbttmbrg
@sean-freeman