-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Scope
This collection requires bump up to 1.0.0 release, but it will require some major rework to ensure that:
- Code quality is improved.
- Hardcoded content is removed.
- Missing validations, conditions and asserts are added.
- Obsolete roles and modules are removed.
- Resolve linting errors and wrong variable names
Roles
| Role | Status | Plan |
|---|---|---|
| os_ansible_user | REVIEW PR 43 | Remove role as it is not SAP specific. |
| os_etchosts | REVIEW PR 43 | Remove role as it is not SAP specific. Alternative |
| os_knownhosts | REVIEW PR 43 | Remove role as it is not SAP specific. Alternative |
| sap_control | REVIEW PR 48 | Major rework is required - More info below |
| sap_fapolicy | REVIEW PR 43 | Remove role and point to LSR |
| sap_firewall | REVIEW PR 46 | Complete redesign and rework |
| sap_hana_backint | TODO | Major rework is required - More info below |
| sap_hana_sr_takeover | TODO @ehaefele | More info below |
| sap_profile_update | REVIEW PR 47 | Complete redesign and rework |
| sap_rfc | TODO | Major rework is required - More info below |
| sap_rhsm | REVIEW PR 43 | Remove role and point to LSR |
sap_control
- Role should act as wrapper with predefined functions only.
- Add functionality from current
sap_operations/plugins/modulesas new functions in role. - Add validations and improve code quality along with comments and documentation.
sap_hana_backint
- Remove all hardcoded pythons
- Remove all unsecure downloads of unverified files that could leak to security issues!
- Add validations and improve code quality along with comments and documentation.
sap_rfc
- Remove all hardcoded pythons
- Completely redo hardcoded VENV setup, packages, SAP package and touching LD...
- Add validations and improve code quality along with comments and documentation.
sap_profile_update
- Add validations and improve code quality along with comments and documentation
sap_hana_sr_takeover
- Add validations and improve code quality along with comments and documentation
Modules
Review all modules and if they are required. They are shell scripts, not real modules.
Previous dependency on community.sap_libs.sap_system_facts is removed in #48
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request