sap_firewall: Complete redesign and rework #46
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dislaimer
This role will still use existing
ansible.posix.firewalldwithout switching to linux_system_roles.firewall, which needs some care before it can be used.Changes
This role was completely broken down and rebuilt from ground up to follow Ansible best practices, Ansible 2.20 linting and Project guidelines.
Notable changes:
posix.firewalldfails.Tests
This was tested on SLES 15 SP6 and SLES 16.
Further use
@berndfinger @ja9fuchs This will serve as example what I will add to
sap_swpm,sap_hana_installandsap_ha_pacemaker_clusterdirectly in smaller format, without adding extra dependency onsap_operations.