Skip to content

Conversation

@marcelmamula
Copy link

@marcelmamula marcelmamula commented Dec 5, 2025

Dislaimer

This role will still use existing ansible.posix.firewalld without switching to linux_system_roles.firewall, which needs some care before it can be used.

Changes

This role was completely broken down and rebuilt from ground up to follow Ansible best practices, Ansible 2.20 linting and Project guidelines.

Notable changes:

  • Role is now stateful, allowing removal of configuration and idempotency.
  • All variables adjusted to conform with their usage and redesigned to fit their purpose - Breaking change for 1.0
  • Add much needed validations and asserts
  • Separate workflow for predefined presets and custom ports and services.
  • Validation for zones and services to avoid posix.firewalld fails.

Tests

This was tested on SLES 15 SP6 and SLES 16.

Further use

@berndfinger @ja9fuchs This will serve as example what I will add to sap_swpm, sap_hana_install and sap_ha_pacemaker_cluster directly in smaller format, without adding extra dependency on sap_operations.

@marcelmamula marcelmamula changed the title sap_firewall: Complete rework of role sap_firewall: Complete redesign and rework Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant