Skip to content

Mark lines that qlty.sh does not report on as omitted instead of missed #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Mark lines that qlty.sh does not report on as omitted instead of missed #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions src/github-injector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,12 @@ import { SELECTOR_PR_REVIEW_TOOLS } from "./github/components/selectors";

const coverageData = new Map<string, FileCoverage>();

const enum CoverageState {
HIT = 1,
MISS = 0,
OMIT = -1,
}

export function tryInjectDiffUI(): void {
try {
tryInjectDiffCommitUI();
Expand Down Expand Up @@ -256,6 +262,13 @@ async function injectIntoFileContainer(
}
}

function hitCountToState(hitCount: number): CoverageState {
if (hitCount >= 1) return CoverageState.HIT;
if (hitCount === 0) return CoverageState.MISS;

return CoverageState.OMIT;
}

function injectIntoGutterCell(cell: Element, coverage: FileCoverage): void {
cell.querySelectorAll(".qlty-coverage-line").forEach((el) => el.remove());

Expand All @@ -271,16 +284,21 @@ function injectIntoGutterCell(cell: Element, coverage: FileCoverage): void {
return;
}

const hit = coverage.hits[lineNumber] ?? 0;
const coverageStateClassMap = {
[CoverageState.HIT]: 'qlty-coverage-hit',
[CoverageState.MISS]: 'qlty-coverage-miss',
[CoverageState.OMIT]: 'qlty-coverage-omit',
};

const omittedHitCount = -1;
const hitCount = coverage.hits[lineNumber] ?? omittedHitCount;

const coverageState = hitCountToState(hitCount);
const coverageClass = coverageStateClassMap[coverageState];

const el = cell.appendChild(document.createElement("div"));
el.classList.add("qlty-coverage-gutter");
if (hit > 0) {
el.classList.add("qlty-coverage-hit");
} else if (hit === 0) {
el.classList.add("qlty-coverage-miss");
} else if (hit < 0) {
el.classList.add("qlty-coverage-omit");
}
el.classList.add(coverageClass);
}

function injectCoverageSummary(
Expand Down