Mark lines that qlty.sh does not report on as omitted instead of missed #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the coverage state representation by distinguishing between lines that are missed (no coverage) versus lines that are omitted (not tracked for coverage). The change introduces proper state management using an enum and updates the default behavior to mark untracked lines as omitted rather than missed.
- Introduces a
CoverageStateenum to clearly define the three coverage states (hit, miss, omit) - Changes the default hit count from
0(miss) to-1(omit) for lines not reported by qlty.sh - Refactors the coverage class assignment logic to use a state-based mapping approach
dejan-lukic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, lines that qlty.sh does not report on get marked as missed (see pic below).
This PR introduces a
CoverageStateenum for the coverage state and maps those stats to the relevantqlty-coverage-{state}css class. It also defaults thehitCountto-1(omit) instead of0(miss)Before
After