Add listDirectory() to Path type and deprecate listFiles()
#6581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
christopher-hakkaart
approved these changes
Nov 20, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Ben Sherman <[email protected]>
bentsherman
changed the title
listFiles() from Path[] to List<Path>listDirectory() to Path type and deprecate listFiles()
bentsherman
force-pushed
the
6152-fix-listfiles-return-type
branch
from
b43bdd5 to
e2d4161
Compare
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6152
The
listFiles()method is problematic because the implementation returns aPath[]instead of aCollection<Path>. The array type supports most of the same functionality, but not all, leading to weird bugs such as not being able to supply as a process path input.Additionally, TaskPath does not implement
listFiles()correctly, which leads to strange errors when callinglistFiles()on a task input in the task body.Introduce
listDirectory()as a replacement forlistFiles()that doesn't have the above issuesDeprecate
listFiles()in the Nextflow language (doesn't need to be deprecated in the runtime)Clean up documentation of Path type