Dracula theme

[SwarupKharul]

What does this PR do?
Added support for dracula theme

Partial fix for #1133

Tested?

• Manually
• Existing tests (adapted, if necessary)
• New tests added (for any new behavior)
• Passed linting & tests (each commit)

Commit flow

• first commit add necessary files
• fix typo

Notes & Questions

• referred official dracula

Visual changes

[neiljp]

@SwarupKharul This looks like a good already - thanks for investigating! 👍

I left some notes on style inline, and also while a lot of the colors appear to match, the references aren't to the colors or the dracula theme website - which maybe slightly disagree with the .vim file?

It looks like the linters should be fixable by running isort and black. The tests are failing since there is no data in the style for syntax highlighting, which the theme contribution guide may have not been updated for yet (it was added over the Summer).

[neiljp]

This link seems to be a file that indicates how the colors are used, rather than the actual color specification?

I found another (.vim) file in that repo that seems to (mostly) match the colors you added, but there are also colors in the official dracula theme website that seem slightly different, at least the darker ones?

The 'h' codes seem to approximate the .vim numbers; are these equivalent to the numbers in the dracula theme itself, do you know? These seem quite different, so I'm not sure if they're a different system.

[neiljp]

Isn't this FG ?

[SwarupKharul]

Yes

[SwarupKharul]

@SwarupKharul This looks like a good already - thanks for investigating! 👍

I left some notes on style inline, and also while a lot of the colors appear to match, the references aren't to the colors or the dracula theme website - which maybe slightly disagree with the .vim file?

It looks like the linters should be fixable by running isort and black. The tests are failing since there is no data in the style for syntax highlighting, which the theme contribution guide may have not been updated for yet (it was added over the Summer).

Thank you @neiljp! I will go through the recommended changes and do the needful.

[neiljp]

@SwarupKharul Please let us know if you need more help :)

[SwarupKharul]

@neiljp I have made the required changes.

[zulipbot]

Heads up @SwarupKharul, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

[neiljp]

@SwarupKharul Belated thanks for this again :)

You had failing tests, and indeed the theme is missing some elements and has some invalid ones.
Some of this may be since some code was merged between when you copied the base theme and pushing it here, such as extra required styles and code block styling (META).

In looking what was wrong, I've adjusted some tests, documentation and now have #1160 pending which should reduce some of the challenges in theme contribution.

[neiljp]

For reference, the pygments we now depend upon should support syntax highlighting with a dracula pygments style.