Realm emoji test update #1026
Merged
Realm emoji test update #1026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve `test__handle_update_emoji_event` by specifying expected emoji type in active emoji data for variations in emoji data.
`EmojiType` specifies types of emoji in the Zulip API.
neiljp
force-pushed
the
realm_emoji_test_update
branch
from
3a3ee71 to
d0307fe
Compare
|
@mkp6781 Thanks for the followup! Made a few minor adjustments to commit text before merging but looked fine otherwise 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up to #827. Based on @neiljp suggestions, I have 2 commits in this PR.
1st commit: Test for
handle_update_emoji_eventimproved. Specifies the type of expected updated emoji inmodel.active_emoji_data.2nd commit: Refactor commit to extract type of emoji into
api_typesas EmojiType.