Add DM narrows; clean up DM recipients some more in API #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
approved these changes
Jun 8, 2023
test/example_data.dart
Outdated
| @@ -63,28 +63,28 @@ final _messagePropertiesBase = { | |||
| }; | |||
|
|
|||
| // When we have a User object, this can take that as an argument. | |||
There was a problem hiding this comment.
// When we have a User object, this can take that as an argument.This comment can now be removed.
These are useful for tests.
This is cheap to just do -- the lists should be short -- and it saves us some headache having to deal with potentially-unsorted lists later.
This takes care of the bulk of zulip#142. The only thing missing is a way to navigate to one of these narrows, which we'll add next.
|
Thanks for the review! Merging, with that fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #142. Along the way, we also make the list of recipients of a DM somewhat cleaner to deal with, in particular by sorting it canonically up front; and we add a bit more testing infrastructure.
Fixes: #142