More error tolerance in migrating legacy data #1595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks, please merge at will! 🚀 |
I believe the legacy app never actually leaves behind data that would trigger this. But if it does, avoid throwing an exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, if the legacy app's account list contains multiple entries with the same realm and user ID (though different emails), we'll drop all but the most-recently-used one because this app's accounts table keeps (realmUrl, userId) unique. With this change, we still drop the duplicates, but we catch the exception and proceed smoothly to the next account in the list.
Ideally these changes would be tested. We'll leave that as part of the followup issue #1593, which covers this whole file.