integrations: Enhanced matrix bridge. (Fix #723) #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this does not seem to work. Unfortunately without useful error message in the logs :/ |
ro-i
force-pushed
the
matrix-multiple-bridges-fix-windows
branch
from
dbccca2 to
37d8fa3
Compare
|
The Windows tests now succeed, just the code coverage is not yet happy... |
|
Can you highlight the change you made that makes it work on Windows? I couldn't spot any difference. The requirements.txt looks the same. |
|
Strange. The coverage should have been identical to 12b5e7a. |
ro-i
force-pushed
the
matrix-multiple-bridges-fix-windows
branch
from
37d8fa3 to
e98d185
Compare
ro-i
force-pushed
the
matrix-multiple-bridges-fix-windows
branch
from
e98d185 to
daacae6
Compare
|
Merged, thanks @ro-i! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :) This PR aims to fix #723 for Windows.
As discussed there, python-magic seems to be problematic on Windows. However, I noticed in the output of the CI that
python-magic-bindoesn't get installed as requested. (It's needed to provide the Windows library support as described here). Thus, my first attempt to fix the Windows support is trying to getpython-magic-binproperly installed. If this doesn't work, I disable the magic-support in Windows completely.