Rspec 3 #133
Merged
Rspec 3 #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecations inside of RAD still exist
RSpec doesn't like that it's private in a real app.
Still failing because of example_request not being able to set the file and location metadata
|
This needs to be a new major version, and probably creating a new branch for current master to follow rspec-2 for a while. |
Conflicts: Gemfile.lock rspec_api_documentation.gemspec
|
When it will be published over Rubygems? |
|
^ +1 for right now i am just doing: |
|
Ok, I'm using the |
|
I pushed 4.0.0 which has this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative pull request for upgrading to RSpec 3 compatibility.
Right now all deprecations are removed. One big thing we lost was the file_path and location here. I'd really like to try and get that back before merging this in.