Skip to content

Conversation

@viragtripathi
Copy link
Contributor

 Implements comprehensive CockroachDB integration with these features:

 Core Features:
 - CockroachDB vector index support using C-SPANN algorithm (v25.2+)
 - Production connection pooling (100+ base connections, configurable)
 - Automatic retry logic for transient errors (40001, 40003)
 - Multi-region resilience with proper error handling
 - Support for L2, Cosine, and Inner Product distance metrics
 - Vector index tuning (partition size, beam size parameters)
 - Filter support (NumGE, StrEqual)

 Implementation:
 - vectordb_bench/backend/clients/cockroachdb/cockroachdb.py: Main client with retry logic
 - vectordb_bench/backend/clients/cockroachdb/config.py: Configuration classes
 - vectordb_bench/backend/clients/cockroachdb/db_retry.py: Retry decorator with exponential backoff
 - vectordb_bench/backend/clients/cockroachdb/cli.py: CLI parameter definitions
 - tests/test_cockroachdb.py: Comprehensive test suite
 - pyproject.toml: Added cockroachdb optional dependencies

 References:
 - CockroachDB Vector Indexes: https://www.cockroachlabs.com/docs/stable/vector-indexes
 - Retry Best Practices: https://cockroachlabs.com/docs/stable/advanced-client-side-transaction-retries

@viragtripathi viragtripathi marked this pull request as draft November 7, 2025 00:35
@viragtripathi viragtripathi force-pushed the add-cockroachdb-support branch 3 times, most recently from faadd37 to 7d33c78 Compare November 7, 2025 14:39
@viragtripathi viragtripathi marked this pull request as ready for review November 7, 2025 14:41
@viragtripathi viragtripathi force-pushed the add-cockroachdb-support branch 2 times, most recently from 9e9ef6f to b336094 Compare November 10, 2025 02:27
@viragtripathi
Copy link
Contributor Author

/assign @XuanYang-cn

@alwayslove2013
Copy link
Collaborator

@viragtripathi Thank you so much for your contribution!

We noticed there are some conflicts in this pull request. Could you please resolve them? After that, we'll be happy to merge it.

     - UUID PRIMARY KEY for distributed write performance
     - Connection pooling with 100+ base connections
     - Comprehensive retry logic for transient errors (40001, 40003)
     - C-SPANN vector index with tunable parameters
     - CLI integration with full parameter support
@viragtripathi viragtripathi force-pushed the add-cockroachdb-support branch from b336094 to ce5ea92 Compare November 25, 2025 13:29
@viragtripathi
Copy link
Contributor Author

viragtripathi commented Nov 25, 2025

@viragtripathi Thank you so much for your contribution!

We noticed there are some conflicts in this pull request. Could you please resolve them? After that, we'll be happy to merge it.

@alwayslove2013 Thank you!
I've resolved the conflicts by rebasing on the latest main branch. The implementation is ready for review and merge. Please let me know if you need any changes!

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alwayslove2013, viragtripathi
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alwayslove2013 alwayslove2013 merged commit fb0d120 into zilliztech:main Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants