Skip to content

Use KeyError when throwing a missing security material exception #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2022
Merged

Use KeyError when throwing a missing security material exception #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b960f9
Use `KeyError` when throwing a missing security material exception
puddly Oct 7, 2022
07cd176
Update unit test
puddly Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/tools/test_network_backup_restore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ async def test_nwk_frame_counter_zstack33(make_connected_znp):
znp.network_info, extended_pan_id=t.EUI64.convert("11:22:33:44:55:66:77:88")
)

with pytest.raises(ValueError):
with pytest.raises(KeyError):
await security.read_nwk_frame_counter(znp)

# Writes similarly will fail
Expand Down
2 changes: 1 addition & 1 deletion zigpy_znp/znp/security.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ async def read_nwk_frame_counter(znp: ZNP, *, ext_pan_id: t.EUI64 = None) -> t.u
global_entry = entry

if global_entry is None:
raise ValueError("No security material entry was found for this network")
raise KeyError("No security material entry was found for this network")

return global_entry.FrameCounter

Expand Down