Fix darwin ulock usage on macOS #9545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
Aug 11, 2021
daurnimator
added
the
standard library
daurnimator
reviewed
Aug 12, 2021
daurnimator
reviewed
Aug 12, 2021
Contributor
|
Nice, any other changes you wish to make? |
Contributor
Author
|
Nope, unless anybody has issues I think its good to land |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was doing macOS ulock stuff, and was linked to Zig's DarwinFutex implementation by @kprotty. There were a few bugs I noticed:
__ulock_wait2actually timeout as au64, notu32(this likely happens to work on at least x86_64 because of how the ABI works, but I can't say about others, and it's still UB either way).__ulock_wait2's timeout is in units of nanoseconds (this would just lead to waking up early which callers have to handle, but still).r? @kprotty