-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Allow tests to fail #8686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tests to fail #8686
Conversation
😂 |
andrewrk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
|
Oops, just noticed this is a draft. Apologies for the premature review. |
eff9cda to
9c34e07
Compare
|
yeah!! |
allow testType() to fail too.
|
What's the recommended way of updating existing code for this? I have so many tests... D= |
Basically just doing what I did in this pr, slap a bunch of |
|
Yeah kind of... definitely not that easy if you wrote any kind of |
Should update most things correctly 😁 |
Closes #8629
There sure are a lot of tests