Skip to content

Conversation

@alexrp
Copy link
Member

@alexrp alexrp commented Jul 7, 2025

Closes #8734.

@alexrp alexrp enabled auto-merge (rebase) July 7, 2025 18:00
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behavior tests must not use expectEqual. It depends too much on std lib.

@andrewrk andrewrk disabled auto-merge July 7, 2025 18:01
@alexrp
Copy link
Member Author

alexrp commented Jul 7, 2025

Are you suggesting simply closing #8734 then?

Also FWIW:

❯ git grep expectEqual test/behavior | wc -l
1058

@andrewrk
Copy link
Member

andrewrk commented Jul 7, 2025

Best case scenario, add behavior test coverage for it that does not depend on expectEqual, and does a minimal reproduction of the issue.

Or also acceptable, just close the issue and count on fuzzing to catch all such bugs later.

@andrewrk
Copy link
Member

andrewrk commented Jul 7, 2025

Also FWIW:

I'm aware 🥲

@alexrp
Copy link
Member Author

alexrp commented Jul 7, 2025

Or also acceptable, just close the issue and count on fuzzing to catch all such bugs later.

I say we go with this then, because there's no readily available repro anywhere that I can find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miscompilation of functions with non-byte-multiple types on i386

2 participants