std.testing: Fully absorb expectEqualBytes into expectEqualSlices
#13816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expectEqualByteswas added as a standalone functionexpectEqualBytesfor large inputs and makeexpectEqualSlicesuse it #13723,expectEqualSliceswas made to useexpectEqualByteswhen the type was u8expectEqualSliceshas fully absorbedexpectEqualBytes, andexpectEqualBytesitself has been removedFor
u8,expectEqualSlicesworks asexpectEqualBytesdid before. For non-u8types,expectEqualSliceswill now work similarly toexpectEqualBytes(highlighting diffs in red), but will use a full line for each index and therefore will only print a maximum of 16 indexes.This should address all the TODO comments that were in
expectEqualSlices.The most dramatic improvement is when the slice lengths differ. Here's an example with
u32as the type:Before:
After:
