-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Closed
Labels
bugObserved behavior contradicts documented or intended behaviorObserved behavior contradicts documented or intended behaviorcontributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.This issue is limited in scope and/or knowledge of Zig internals.standard libraryThis issue involves writing Zig code for the standard library.This issue involves writing Zig code for the standard library.
Milestone
Description
zig/lib/std/os/linux/io_uring.zig
Line 2027 in 9622991
const address_server = try net.Address.parseIp4("127.0.0.1", 3131); |
zig/lib/std/os/linux/io_uring.zig
Line 2519 in 9622991
const address = try net.Address.parseIp4("127.0.0.1", 3131); |
zig/lib/std/os/linux/io_uring.zig
Line 3239 in 9622991
const address = try net.Address.parseIp4("127.0.0.1", 3131); |
You can't just grab some arbitrary port and start using it in unit tests. That port could be used by the system causing the unit tests to fail with EADDRINUSE. Or... it could be used by the very same unit tests, in another process, which is the situation happening now, in #14647. Unit tests must bind to port 0, letting the operating system assign a port, and then use that port for testing.
I will now disable all of these tests that hard code a port number.
lin72h
Metadata
Metadata
Assignees
Labels
bugObserved behavior contradicts documented or intended behaviorObserved behavior contradicts documented or intended behaviorcontributor friendlyThis issue is limited in scope and/or knowledge of Zig internals.This issue is limited in scope and/or knowledge of Zig internals.standard libraryThis issue involves writing Zig code for the standard library.This issue involves writing Zig code for the standard library.