-
Notifications
You must be signed in to change notification settings - Fork 8.2k
boards: nxp: mcx_n9xx_evk: unify compat between variants #99091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Harmonize board compats between `mcx_n9xx_evk/mcxn947/cpu0(/qspi)` and `mcx_n9xx_evk/mcxn947/cpu1` variants. Signed-off-by: Patryk Koscik <[email protected]>
c5441a4 to
2da42ad
Compare
|
|
|
||
| / { | ||
| aliases{ | ||
| compatible = "nxp,mcxn947", "nxp,mcx"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just thinking. Should it be part of SOC dts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, couple of notes
-
mcx_n9xx_evk_mcxn947_cpu*.dtsiare the only947specific files - at least, according to filename. -
There is nxp_mcxn94x_common.dtsi, which (according to filename) seems to be a generic description for the
94xseries.- This file is currently only included in the
nxp_mcxn94x(_ns).dtsiDTs, that are later included in themcx_n9xx_evk_mcxn947_cpu*.dtsiandmcx_n9xx_evk.dtsifiles. - Since
NXP MCX-N9XX-EVKships withMCX-N947- currently this file is only used to describe947based devices. - But filename suggests that this file should stay generic
- This file is currently only included in the
I can prepare a patch to add nxp,mcxn94x to the nxp_mcxn94x_common.dtsi. This would also work for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea
Better to wait for other people's opinions ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this compatible does not seem to actually matter at all, so I have no opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, if we want to be pedantic and bikeshed over this, the root node represents the whole system, not just the SOC. So it should be named after the board.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @butok should be down in the SOC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @butok should be down in the SOC
It should be done for all NXP boards ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If to look at other vendors, it's based on
- Board name
model = "STMicroelectronics STM32F401RE-NUCLEO board";
compatible = "st,stm32f401re-nucleo";
compatible = "nordic,nrf54lm20dk_nrf54lm20a-cpuapp";
model = "Nordic nRF54LM20 DK nRF54LM20A Application MCU";
- both board and all SOCs
model = "Atmel SAM V71 Xplained Ultra board";
compatible = "atmel,sam_v71_xult", "atmel,samv71q21", "atmel,samv71";
model = "Arduino Nano Matter";
compatible = "arduino,arduino_nano_matter", "silabs,mgm240sd22vna";
I guess the 2nd option is more complete.
BUT I do not know how and where it's used, or if it's just for informational needs. Do you know something about it?



Harmonize board compats between
mcx_n9xx_evk/mcxn947/cpu0(/qspi)andmcx_n9xx_evk/mcxn947/cpu1variants.