Skip to content

Conversation

@pkoscik
Copy link
Contributor

@pkoscik pkoscik commented Nov 7, 2025

Harmonize board compats between mcx_n9xx_evk/mcxn947/cpu0(/qspi) and mcx_n9xx_evk/mcxn947/cpu1 variants.

Harmonize board compats between `mcx_n9xx_evk/mcxn947/cpu0(/qspi)` and
`mcx_n9xx_evk/mcxn947/cpu1` variants.

Signed-off-by: Patryk Koscik <[email protected]>
@pkoscik pkoscik force-pushed the 84381-mcxn947-compat branch from c5441a4 to 2da42ad Compare November 7, 2025 15:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 7, 2025


/ {
aliases{
compatible = "nxp,mcxn947", "nxp,mcx";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just thinking. Should it be part of SOC dts?

Copy link
Contributor Author

@pkoscik pkoscik Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, couple of notes

  • mcx_n9xx_evk_mcxn947_cpu*.dtsi are the only 947 specific files - at least, according to filename.

  • There is nxp_mcxn94x_common.dtsi, which (according to filename) seems to be a generic description for the 94x series.

    • This file is currently only included in the nxp_mcxn94x(_ns).dtsi DTs, that are later included in the mcx_n9xx_evk_mcxn947_cpu*.dtsi and mcx_n9xx_evk.dtsi files.
    • Since NXP MCX-N9XX-EVK ships with MCX-N947 - currently this file is only used to describe 947 based devices.
    • But filename suggests that this file should stay generic

I can prepare a patch to add nxp,mcxn94x to the nxp_mcxn94x_common.dtsi. This would also work for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

Better to wait for other people's opinions ;)

Copy link
Member

@decsny decsny Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this compatible does not seem to actually matter at all, so I have no opinion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, if we want to be pedantic and bikeshed over this, the root node represents the whole system, not just the SOC. So it should be named after the board.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @butok should be down in the SOC

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @butok should be down in the SOC

It should be done for all NXP boards ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If to look at other vendors, it's based on

  1. Board name
model = "STMicroelectronics STM32F401RE-NUCLEO board";
compatible = "st,stm32f401re-nucleo";
compatible = "nordic,nrf54lm20dk_nrf54lm20a-cpuapp";
model = "Nordic nRF54LM20 DK nRF54LM20A Application MCU";
  1. both board and all SOCs
model = "Atmel SAM V71 Xplained Ultra board";
compatible = "atmel,sam_v71_xult", "atmel,samv71q21", "atmel,samv71";
model = "Arduino Nano Matter";
compatible = "arduino,arduino_nano_matter", "silabs,mgm240sd22vna";

I guess the 2nd option is more complete.

BUT I do not know how and where it's used, or if it's just for informational needs. Do you know something about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Boards/SoCs platform: NXP MCU platform: NXP NXP size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants