tests: net: dns-sd: Cleanup tests and fix undefined behavior #92341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the code to use the standard struct in_addr for representing IPv4 addresses instead of a uint32_t combined with the custom IP_ADDR macro. Signed-off-by: Tim Pambor <[email protected]>
htons() takes uint16_t as argument. Add the 'u' suffix to the TTL constants to ensure the correct unsigned type is used and to avoid undefined behavior if these functions are implemented as macros using bit shifts. Signed-off-by: Tim Pambor <[email protected]>
1 task
|
jukkar
approved these changes
Jun 28, 2025
rlubos
approved these changes
Jun 30, 2025
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following errors reported by UBSAN
This is a step towards fixing #90882.