boards: st: stm32 add the SD disk name to boards with sdmmc node #89086
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRASTM
requested review from
JarmouniA,
JordanYates,
djiatsaf-st,
erwango,
gautierg-st and
marwaiehm-st
and removed request for
JarmouniA
erwango
requested changes
Apr 25, 2025
Member
erwango
left a comment
erwango
left a comment
There was a problem hiding this comment.
LGTM, but if this prop is now mandatory, let's make it required: true in dts/bindings/mmc/st,stm32-sdmmc.yaml
Contributor
|
Sorry for the failures, weird that CI didn't pick it up on my PR. Change looks fine, I agree with @erwango RE making the property required |
This PR makes the property disk-name required for the st,stm32-sdmmc compatible Signed-off-by: Francois Ramu <[email protected]>
Contributor
Author
|
with and adding the |
github-actions
bot
added
area: Clock Control
area: Samples
github-actions
bot
requested review from
GeorgeCGV,
Laczen,
danieldegrasse,
de-nordic,
decsny,
jfischer-no,
kartben,
mathieuchopstm,
nashif and
nordic-krch
Contributor
Author
|
with more non-ST boards |
erwango
previously approved these changes
Apr 28, 2025
mathieuchopstm
previously approved these changes
Apr 28, 2025
Add a disk name to the SDMMC node, as done for all other SD card compatibles in tree. Signed-off-by: Francois Ramu <[email protected]>
gautierg-st
approved these changes
Apr 28, 2025
erwango
approved these changes
Apr 28, 2025
mathieuchopstm
approved these changes
Apr 28, 2025
Member
|
@de-nordic Do you want to remain as assignee ? Otherwise I can take it |
danieldegrasse
approved these changes
Apr 29, 2025
Member
|
Taking assignment as this issue is blocking others in CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a disk name to the SDMMC node, as done for all other SD card compatibles in tree.
Like the PR #88691 did for the stm32h747 disco
Fixes #89081