Skip to content

Conversation

@alxelax
Copy link
Contributor

@alxelax alxelax commented Jun 21, 2023

Provisionee shall fail if provisioner sent public key identicall to OOB public key back.

Provisionee shall fail if provisioner sent public key
identicall to OOB public key back.

Signed-off-by: Aleksandr Khromykh <[email protected]>
Copy link
Contributor

@PavelVPV PavelVPV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also compare the generated public key (when provisioning without OOB Public Key) with the received one?

@alxelax
Copy link
Contributor Author

alxelax commented Jun 21, 2023

Should we also compare the generated public key (when provisioning without OOB Public Key) with the received one?

This key has not been sent yet. Nobody saw it. Of course, they can coincide occasionally, but this is a question then to Zephyr's random functionality.
Any case, provisioner will reject such key.

@carlescufi carlescufi merged commit 10ef3b4 into zephyrproject-rtos:main Jun 21, 2023
@alxelax alxelax deleted the fix_provee_pubkey_bug branch June 21, 2023 14:59
@alxelax alxelax restored the fix_provee_pubkey_bug branch July 6, 2023 08:59
@alxelax alxelax deleted the fix_provee_pubkey_bug branch July 14, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants