-
Notifications
You must be signed in to change notification settings - Fork 8.2k
mcumgr fs management security information #26083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
while this PR documents the security problems with FS, are we in general agreement that this should close #22340? Documenting the problem was only one of the potential solutions and I'm not sure there was general agreement that it would be acceptable to close the issue if we did document it? |
That is still an open question, I particularly don't think restrict access to specific folders is a valid fix, we would just hiding a bigger problem. Again, unless we have a better proposal I think that is the way to go. |
subsys/mgmt/Kconfig.mcumgr
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't read well. Something like this would be more clear.
This option allows mcumgr clients to access anything in the file system, including application-stored secrets like private keys. Use of this feature in production is strongly discouraged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, thanks !
Add a warning in fs mgmt option about security risks. Signed-off-by: Flavio Ceolin <[email protected]>
scripts/kconfig/hardened.csv
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newline
MCMUMGR file system management is discouraged in production, just adding it to the recommendation list. Signed-off-by: Flavio Ceolin <[email protected]>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v1.14-branch v1.14-branch
# Navigate to the new working tree
cd .worktrees/backport-v1.14-branch
# Create a new branch
git switch --create backport-26083-to-v1.14-branch
# Cherry-pick the merged commits of this pull request and resolve the conflicts
git cherry-pick b429b126099caa5e7984719aebe77583cdf25d36~2..b429b126099caa5e7984719aebe77583cdf25d36
# Push it to GitHub
git push --set-upstream origin backport-26083-to-v1.14-branch
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v1.14-branchThen, create a pull request where the |
Add security information about enabling fs management for mcumgr.
Closes #22340