Revert "Update Array to respect FSStore's key_separator (#718)" #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Codecov Report
@@ Coverage Diff @@
## master zarr-developers/zarr-python#729 +/- ##
==========================================
- Coverage 99.94% 99.92% -0.02%
==========================================
Files 28 28
Lines 10442 10408 -34
==========================================
- Hits 10436 10400 -36
- Misses 6 8 +2
|
|
@jakirkham @d-v-b @martindurant @grlee77 : I'll be disappearing for the evening soon, but if #709 is unlikely to go green and this needs to go out, 👍 |
jakirkham
approved these changes
Apr 29, 2021
|
Thanks Josh! 😄 This seems fine to revert for now. We can rework things in PR ( #709 ) and hopefully address the motivating use cases that way 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 449ed26.
see: #709 zarr-developers/n5py#12