Skip to content

Fix type of v2 compressors #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 11, 2025
Merged

Conversation

dstansby
Copy link
Contributor

Because __init__ parses a CompressorLikev2 input, I think the actual attribute type should simply be a Codec or None.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 11, 2025
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Jul 11, 2025
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (7154f98) to head (df9a2aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3232   +/-   ##
=======================================
  Coverage   94.76%   94.76%           
=======================================
  Files          78       78           
  Lines        8672     8672           
=======================================
  Hits         8218     8218           
  Misses        454      454           
Files with missing lines Coverage Δ
src/zarr/core/metadata/v2.py 92.66% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dstansby dstansby marked this pull request as ready for review July 11, 2025 16:20
@d-v-b d-v-b enabled auto-merge (squash) July 11, 2025 17:51
@d-v-b d-v-b merged commit dfd672b into zarr-developers:main Jul 11, 2025
30 checks passed
@dstansby dstansby deleted the v2-metadata-comp-type branch July 12, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants