Skip to content

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Jun 3, 2025

This cleans up the implementation of create() a bit by:

  • Fixing the typing of filters
  • Removing duplicate parsing of data type and compressor (the parsing is already done further down the call stack)
  • Moving the parsing of filters to be in the same place (further down the call stack) as parsing of compressor

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 3, 2025
@d-v-b
Copy link
Contributor

d-v-b commented Jun 3, 2025

thank you for this cleanup work 🙏

@dstansby dstansby removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 7, 2025
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 7, 2025
@dstansby dstansby removed the needs release notes Automatically applied to PRs which haven't added release notes label Jun 9, 2025
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jun 17, 2025
@dstansby dstansby requested a review from d-v-b June 17, 2025 08:18
@dstansby dstansby requested a review from a team July 6, 2025 20:20
@dstansby
Copy link
Contributor Author

dstansby commented Jul 9, 2025

Since this seems uncontroversial, and has plenty of time for review, I'm going to self merge if CI passes.

@dstansby
Copy link
Contributor Author

dstansby commented Jul 9, 2025

Bah, I can't self merge 😄 - can someone review please?

Copy link

codecov bot commented Jul 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (23edb80) to head (d853cf0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3111      +/-   ##
==========================================
+ Coverage   94.72%   94.76%   +0.04%     
==========================================
  Files          78       78              
  Lines        8646     8642       -4     
==========================================
  Hits         8190     8190              
+ Misses        456      452       -4     
Files with missing lines Coverage Δ
src/zarr/api/asynchronous.py 87.50% <100.00%> (+1.00%) ⬆️
src/zarr/api/synchronous.py 94.66% <ø> (ø)
src/zarr/core/array.py 98.46% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dstansby dstansby enabled auto-merge (squash) July 9, 2025 20:21
@dstansby dstansby removed the needs release notes Automatically applied to PRs which haven't added release notes label Jul 9, 2025
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 9, 2025
@dstansby dstansby merged commit 9d97b24 into zarr-developers:main Jul 9, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants