Skip to content

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Dec 8, 2024

This should fix #2016, by fetching tags during the readthedocs build. Fix taken from https://github.com/sunpy/sunpy/blob/8c35f7e0fdf46d77faaaa34a1a47e440332326dc/.readthedocs.yaml#L7C3-L9C38.

I also updated the setuptools_scm configuration to match their current docs, just to be safe.

@dstansby dstansby added the V2 Affects the v2 branch label Dec 8, 2024
@dstansby dstansby added this to the 2.18.4 milestone Dec 8, 2024
@dstansby dstansby marked this pull request as draft December 8, 2024 13:21
@dstansby dstansby marked this pull request as ready for review December 11, 2024 16:54
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR shows Version: 2.18.4.dev19 but so do other PRs (e.g., https://zarr--2552.org.readthedocs.build/en/2552/, Version: 2.18.4.dev18)

That being said, the code changes look sane. 👍

@dstansby dstansby merged commit 10a4629 into zarr-developers:support/v2 Dec 12, 2024
15 checks passed
@dstansby dstansby deleted the docs-version branch December 12, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 Affects the v2 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants