Skip to content

handle empty string prefix in zipstore delete dir #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2024
Merged

handle empty string prefix in zipstore delete dir #2492

merged 2 commits into from
Nov 15, 2024

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Nov 15, 2024

Zipstore's implementation of delete_dir was not normalizing input paths correctly, resulting in the empty string '' being replaced with '/', which would fail to match anything.

@d-v-b d-v-b requested review from jhamman and dstansby November 15, 2024 16:57
@d-v-b d-v-b merged commit 6e4b1fd into zarr-developers:main Nov 15, 2024
26 checks passed
@d-v-b d-v-b deleted the fix/zipstore-delete-dir branch November 15, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

@dstansby dstansby Awaiting requested review from dstansby

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-v-b @jhamman