Fix JSON encoding of complex fill values #2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not replacing NaNs and Infs with the string versions.
d-v-b
reviewed
Oct 22, 2024
| store = MemoryStore({}, mode="w") | ||
| Array.create(store=store, shape=(1,), dtype=np.complex64, fill_value=fill_value) | ||
| content = await store.get("zarr.json", prototype=default_buffer_prototype()) | ||
| assert content is not None |
There was a problem hiding this comment.
won't we get an error later in the test if content is None? or is this just for mypy (in which case I'd prefer explicitly ignore the type error)?
There was a problem hiding this comment.
that store.get can return None is an unfortunate part of our store API that we need to fix IMO...
dcherian
commented
Oct 23, 2024
jhamman
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not replacing NaNs and Infs with the string versions.
[Description of PR]
TODO: