Skip to content

fix(storage): change StoreTests get/set methods to async #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 9, 2024
Merged

fix(storage): change StoreTests get/set methods to async #2313

merged 2 commits into from
Oct 9, 2024

Conversation

@jhamman
Copy link
Member

@jhamman jhamman commented Oct 8, 2024

Small change that supports storage backends that don't have a synchronous interface

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@jhamman jhamman requested a review from d-v-b October 8, 2024 19:49
@jhamman jhamman force-pushed the fix/store-test-get-set-async branch from fada53e to 474947c Compare October 8, 2024 19:51
@jhamman jhamman merged commit 8f4ef26 into zarr-developers:v3 Oct 9, 2024
20 checks passed
@jhamman jhamman deleted the fix/store-test-get-set-async branch October 9, 2024 04:40
@jhamman jhamman added the V3 label Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TomAugspurger TomAugspurger TomAugspurger approved these changes

@d-v-b d-v-b Awaiting requested review from d-v-b

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhamman @TomAugspurger