Skip to content

Conversation

dstansby
Copy link
Contributor

This finishes most of the typing for zarr.group. I think (at least for now) typing all the kwargs as Any is the best we can do?

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think (at least for now) typing all the kwargs as Any is the best we can do?

I think that is right. Once we have all of these convenience methods implemented, I we can probably do a better job typing the implementations.

@dstansby dstansby marked this pull request as ready for review May 14, 2024 08:44
@jhamman jhamman merged commit 67b07fb into zarr-developers:v3 May 15, 2024
@jhamman jhamman added the V3 label May 15, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone May 15, 2024
@dstansby dstansby deleted the type-group branch May 15, 2024 16:00
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants