Skip to content

Remove unused typing ignore comments #1781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2024
Merged

Remove unused typing ignore comments #1781

merged 2 commits into from
Apr 11, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Apr 9, 2024

I'm going to be putting in a few PRs to improve typing in the v3 branch 🕺

This one removes unused typing ignore comments. (and for good measure adds a couple of other mypy options that didn't require any extra fixes)

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dstansby dstansby force-pushed the mypy-unused-ignore branch from bdbe4d7 to 5b332b9 Compare April 9, 2024 20:21
jhamman
jhamman approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dstansby! Keep 'em coming!

@dstansby dstansby mentioned this pull request Apr 10, 2024
Closed
16 tasks
@d-v-b
Copy link
Contributor

d-v-b commented Apr 11, 2024

thanks @dstansby, this is going in

@d-v-b d-v-b merged commit 3a9d968 into zarr-developers:v3 Apr 11, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 22, 2024
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
types
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @d-v-b @jhamman @sanketverma1704