Skip to content

Allow dmypy to be run on v3 branch #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2024
Merged

Allow dmypy to be run on v3 branch #1780

merged 1 commit into from
Apr 11, 2024

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Apr 9, 2024 •
edited
Loading

This allows dmypy, the mypy daemon to be run on the v3 branch. In turn this allows the mypy plugin to be used in VSCode.

follow_imports is not supported by the daemon, but not needed, and namespace_packages = false is needed so mypy doesn't interpret src/ as a package.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b d-v-b merged commit 3a73950 into zarr-developers:v3 Apr 11, 2024
@dstansby dstansby deleted the dmypy branch April 11, 2024 18:49
@jhamman jhamman added this to the 3.0.0.alpha milestone Apr 22, 2024
@jhamman jhamman added the types label Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

@d-v-b d-v-b d-v-b approved these changes

Assignees
No one assigned
Labels
types
Projects
Zarr-Python - 3.0
Status: Done
Milestone
3.0.0.alpha
Development

Successfully merging this pull request may close these issues.
4 participants
@dstansby @jhamman @d-v-b @sanketverma1704