Skip creation of OwnerReference if user is in a different namespace #2912
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortenlj
requested review from
sdudoladov,
Jan-M,
FxKu,
jopadi,
idanovinda,
hughcapet and
macedigital
as code owners
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
Instead of doing a string compare on the username, check the actual namespace of the user to determine if an owner reference can be created.
mortenlj
force-pushed
the
skip-ownerreference-for-prepareddatabase-secret-namespace
branch
from
4dc43db to
64215b0
Compare
|
Cannot start a pipeline due to: Click on pipeline status check Details link below for more information. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing a string compare on the username, check the actual namespace of the user to determine if an owner reference can be created.
I believe this should fix #2910