Add .editorconfig #5
Open
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thats great. cant accept it though as im a tabs guy myself... 😄 |
|
Well, that's too bad, because In JS community 2 spaces is almost de facto standard. I was tabs guy in past too, and taking spaces wasn't easy for me. But now I'm much happier person for no reason :) Anyway, I recommend to take PR and changes spaces config to tabs. It will eliminate awkward situation for contributors. For example, my Sublime Text 3 even without .editorconfig for some reason assumed that it should convert everything to spaces from tabs... With .editorconfig with set to tabs this won't happen ever. |
|
@yoavniran ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's today's de facto community-accepted standard, see http://editorconfig.org/