Skip to content

[regression] A couple of issues have been closed while the puzzles are still in place #379

@php-coder

Description

@php-coder

The following issues have been mistakenly closed by @0pdd while the puzzles are still in place:

Here are these comments:

$ git grep -2 '@todo #1057 SeriesSaleImportForm: wait until setState() finishes'
src/main/frontend/src/components/SeriesSaleImportForm.js-               event.preventDefault();
src/main/frontend/src/components/SeriesSaleImportForm.js-
src/main/frontend/src/components/SeriesSaleImportForm.js:               // @todo #1057 SeriesSaleImportForm: wait until setState() finishes
src/main/frontend/src/components/SeriesSaleImportForm.js-               // (see https://reactjs.org/docs/react-component.html#setstate)
src/main/frontend/src/components/SeriesSaleImportForm.js-               this.setState({

$ git grep -2 '@todo #1448 AddSimilarSeriesForm.similarSeriesId: remove deprecated member'
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- // @todo #1280 AddSimilarSeriesForm: add integration test for mandatory similarSeriesId
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- // @todo #1280 AddSimilarSeriesForm: similarSeriesId must exist
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java: // @todo #1448 AddSimilarSeriesForm.similarSeriesId: remove deprecated member
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- //
src/main/java/ru/mystamps/web/feature/series/AddSimilarSeriesForm.java- // NOTE: similarSeriesId is deprecated and exist only for backward compatibility

$ git grep -2 '@todo #1054 Extract list of exclusions to a common profile'
src/main/resources/application-postgres.properties-app.use-cdn: false
src/main/resources/application-postgres.properties-
src/main/resources/application-postgres.properties:# @todo #1054 Extract list of exclusions to a common profile
src/main/resources/application-postgres.properties-#
src/main/resources/application-postgres.properties-# Full list of autoconfiguration classes:

It seems like a regression in pdd but could be 0pdd bug as well.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions