download_verify removed on nightly

[KristofferC]

This package uses internals of Pkg when testing e.g.:

ArchGDAL.jl/test/remotefiles.jl

Lines 4 to 6 in 9cc8713

	using Pkg.PlatformEngines
	probe_platform_engines!() # for download

These has been changed on Julia nightly. It would be good to transition these tests to use public functions (e.g. using the download function and then verify using the SHA stdlib).

[zerefwayne]

@yeesian I would like to work on this!

[visr]

That would be great! Could you make it similar to the download_verify that is used now, such that it first checks if the file exists and the SHA matches, before downloading?

[zerefwayne]

@KristofferC I was going through the Julia1.6 project board where I found that Base.download is being replaced by Downloads.jl Should I use that package instead?

[KristofferC]

Personally, I think it is a good idea to use it but I don't maintain this package :)

[zerefwayne]

Okay thanks! @KristofferC Also, it would be helpful if you could guide me to the discussion/PR about removing download_verify from Pkg. I wonder if they have replaced it with something else because the function was pretty well implemented.

[KristofferC]

I don't think there is much discussion about it. There were just some small things in Pkg that changed causing the package to break which is quite common when a package uses the internals of another package. So best to just use the documented, public funtionality.