Skip to content

Fix bloat-gathering script #29822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SammyVimes merged 4 commits into from
Dec 2, 2025
Merged

Fix bloat-gathering script #29822

SammyVimes merged 4 commits into from
Dec 2, 2025

Conversation

@SammyVimes
Copy link
Collaborator

@SammyVimes SammyVimes commented Nov 30, 2025

Changelog entry

Chrome trace format has changed due to clang version update, this PR changes the handling of the traces

Changelog category

  • Not for changelog (changelog entry is not required)

Copilot AI review requested due to automatic review settings November 30, 2025 21:27
@github-actions
Copy link

github-actions bot commented Nov 30, 2025

🟢 2025-11-30 21:30:19 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 21:30:48 UTC Pre-commit check linux-x86_64-relwithdebinfo for bce8937 has started.
⚪ 2025-11-30 21:31:05 UTC Artifacts will be uploaded here
⚪ 2025-11-30 21:33:10 UTC ya make is running...
🟢 2025-11-30 21:33:16 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-30 21:33:21 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Nov 30, 2025 •
edited
Loading

⚪ 2025-11-30 21:31:13 UTC Pre-commit check linux-x86_64-release-asan for bce8937 has started.
⚪ 2025-11-30 21:31:29 UTC Artifacts will be uploaded here
⚪ 2025-11-30 21:33:33 UTC ya make is running...
🟢 2025-11-30 21:33:39 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-11-30 21:33:44 UTC Build successful.

Copilot AI reviewed Nov 30, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a bloat-gathering script that broke due to changes in the Chrome trace format resulting from a clang version update. The script previously expected trace events with a "dur" (duration) field but now needs to handle begin/end event pairs with "ph" (phase) field values of "b" and "e".

Key Changes

  • Refactored build_include_tree to process begin/end event pairs instead of complete duration events
  • Updated parse_includes to match begin and end events using a dictionary to track pending begin events
  • Replaced sorted event processing with stack-based tracking for both functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

maximyurchuk
maximyurchuk previously approved these changes Dec 1, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

⚪ 2025-12-01 11:51:30 UTC Pre-commit check linux-x86_64-relwithdebinfo for 350f6af has started.
⚪ 2025-12-01 11:52:10 UTC Artifacts will be uploaded here
⚪ 2025-12-01 11:54:14 UTC ya make is running...
🟢 2025-12-01 11:54:20 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-01 11:54:25 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

⚪ 2025-12-01 11:52:46 UTC Pre-commit check linux-x86_64-release-asan for 350f6af has started.
⚪ 2025-12-01 11:53:04 UTC Artifacts will be uploaded here
⚪ 2025-12-01 11:55:09 UTC ya make is running...
🟢 2025-12-01 11:55:15 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-01 11:55:21 UTC Build successful.

maximyurchuk
maximyurchuk reviewed Dec 1, 2025
View reviewed changes
@SammyVimes
Disable bloat.json parsing and template_bloat syncing
6866e31 
Commented out lines related to parsing bloat.json and syncing template_bloat files until further development.
@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

⚪ 2025-12-01 12:20:23 UTC Pre-commit check linux-x86_64-release-asan for 6660db6 has started.
⚪ 2025-12-01 12:20:40 UTC Artifacts will be uploaded here
⚪ 2025-12-01 12:22:43 UTC ya make is running...
🟢 2025-12-01 12:22:49 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-01 12:22:54 UTC Build successful.

maximyurchuk
maximyurchuk previously approved these changes Dec 1, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

⚪ 2025-12-01 12:22:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 6660db6 has started.
⚪ 2025-12-01 12:22:42 UTC Artifacts will be uploaded here
⚪ 2025-12-01 12:24:50 UTC ya make is running...
🟢 2025-12-01 12:24:56 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-01 12:25:01 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

⚪ 2025-12-01 18:16:25 UTC Pre-commit check linux-x86_64-relwithdebinfo for 141d22e has started.
⚪ 2025-12-01 18:16:44 UTC Artifacts will be uploaded here
⚪ 2025-12-01 18:18:47 UTC ya make is running...
🟢 2025-12-01 18:18:53 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-01 18:18:58 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 1, 2025 •
edited
Loading

⚪ 2025-12-01 18:16:57 UTC Pre-commit check linux-x86_64-release-asan for 141d22e has started.
⚪ 2025-12-01 18:17:12 UTC Artifacts will be uploaded here
⚪ 2025-12-01 18:19:14 UTC ya make is running...
🟢 2025-12-01 18:19:20 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-01 18:19:25 UTC Build successful.

@SammyVimes SammyVimes enabled auto-merge (squash) December 1, 2025 23:32
@SammyVimes SammyVimes merged commit 20ae461 into main Dec 2, 2025
10 checks passed
@ydbot
Copy link
Collaborator

ydbot commented Dec 2, 2025

Backport

To backport this PR, click the button next to the target branch and then click "Run workflow" in the Run Actions UI.

Branch Run
stable-25-2, stable-25-2-1, stable-25-3, stable-25-3-1 ▶ Backport
stable-25-3, stable-25-3-1 ▶ Backport
stable-25-3 ▶ Backport

▶ Backport manual

@SammyVimes SammyVimes deleted the fix-bloat branch December 2, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@maximyurchuk maximyurchuk maximyurchuk approved these changes

Assignees

No one assigned

Labels

not-for-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@SammyVimes @ydbot @maximyurchuk