feat: specify resource pools when launching a query #3198

astandrik · 2025-12-09T17:11:50Z

CI Results

Test Status: ⚠️ FLAKY

Total	Passed	Failed	Flaky	Skipped
384	380	0	2	2

Test Changes Summary ✨3 ⏭️2

✨ New Tests (3)

Resource pool dropdown is populated from system view (tenant/queryEditor/querySettings.test.ts)
Resource pool selection is persisted between dialog opens (tenant/queryEditor/querySettings.test.ts)
Selected resource pool is sent in API requests and no override omits parameter (tenant/queryEditor/querySettings.test.ts)

⏭️ Skipped Tests (2)

Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
Copy result button copies to clipboard (tenant/queryEditor/queryEditor.test.ts)

Bundle Size: 🔺

Current: 62.50 MB | Main: 62.48 MB
Diff: +0.01 MB (0.02%)

⚠️ Bundle size increased. Please review.

ℹ️ CI Information

Test recordings for failed tests are available in the full report.
Bundle size is measured for the entire 'dist' directory.
📊 indicates links to detailed reports.
🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

greptile-apps

_{8 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/store/reducers/query/utils.ts

Copilot

Pull request overview

This PR adds support for specifying resource pools when launching queries in the YDB Embedded UI. Users can now select a resource pool from a dropdown in the query settings dialog, which will be applied to their query execution.

Key changes:

Added resource pool selection to query settings dialog with support for fetching available pools
Modified query execution to include resource_pool parameter in API requests
Added utility function for applying resource pool pragma to queries (though not currently used)

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/utils/query.ts	Added `RESOURCE_POOL_NO_OVERRIDE_VALUE` constant and `resourcePool` field to query settings schema
src/types/api/query.ts	Added `resource_pool` parameter to `SendQueryParams` interface
src/store/reducers/query/utils.ts	Added `applyResourcePoolPragma` utility function to inject resource pool pragma into queries
src/store/reducers/query/query.ts	Added `getResourcePools` endpoint to fetch available pools and integrated `resource_pool` parameter into query execution
src/store/reducers/query/test/prepareQueryWithPragmas.test.ts	Added comprehensive tests for `applyResourcePoolPragma` function
src/containers/Tenant/Query/QuerySettingsDialog/i18n/ru.json	Added Russian translations for resource pool UI
src/containers/Tenant/Query/QuerySettingsDialog/i18n/en.json	Added English translations for resource pool UI
src/containers/Tenant/Query/QuerySettingsDialog/constants.ts	Added field settings for resource pool selector
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsSelect.tsx	Updated type to support string values for resource pool names
src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx	Added resource pool selector UI component with API integration

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx

src/store/reducers/query/utils.ts

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx

greptile-apps

Additional Comments (1)

src/utils/query.ts, line 309-317 (link)

logic: DEFAULT_QUERY_SETTINGS missing resourcePool field. Should include resourcePool: RESOURCE_POOL_NO_OVERRIDE_VALUE to ensure consistent initialization across the app.

_{6 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/utils/query.ts:317

The resourcePool field is missing from DEFAULT_QUERY_SETTINGS. Since this is a new optional field that can be undefined, it should have a default value specified in DEFAULT_QUERY_SETTINGS (e.g., resourcePool: undefined or resourcePool: RESOURCE_POOL_NO_OVERRIDE_VALUE). This ensures consistent initialization and makes the default behavior explicit.

export const DEFAULT_QUERY_SETTINGS = {
    queryMode: QUERY_MODES.query,
    transactionMode: TRANSACTION_MODES.implicit,
    timeout: null,
    limitRows: 10000,
    statisticsMode: STATISTICS_MODES.none,
    tracingLevel: TRACING_LEVELS.off,
    pragmas: defaultPragma,
};

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx

greptile-apps

_{8 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

src/utils/query.ts:317

The DEFAULT_QUERY_SETTINGS object should include a default value for resourcePool to ensure consistent initialization. Consider adding resourcePool: RESOURCE_POOL_NO_OVERRIDE_VALUE to the defaults. This would prevent undefined values when settings are restored or initialized for the first time, ensuring the "No pool override" option is selected by default.

export const DEFAULT_QUERY_SETTINGS = {
    queryMode: QUERY_MODES.query,
    transactionMode: TRANSACTION_MODES.implicit,
    timeout: null,
    limitRows: 10000,
    statisticsMode: STATISTICS_MODES.none,
    tracingLevel: TRACING_LEVELS.off,
    pragmas: defaultPragma,
};

tests/suites/tenant/queryEditor/querySettings.test.ts

src/utils/query.ts

src/store/reducers/query/query.ts

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

tests/suites/tenant/queryEditor/models/SettingsDialog.ts

greptile-apps

_{11 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

astandrik

we should get resource pools on query editor opening

greptile-apps

_{11 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx

greptile-apps

_{14 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx

Copilot

Pull request overview

Copilot reviewed 16 out of 16 changed files in this pull request and generated 5 comments.

src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx

tests/suites/tenant/queryEditor/querySettings.test.ts

greptile-apps

_{14 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx

astandrik · 2025-12-10T12:23:38Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no bugs!

artemmufazalov · 2025-12-10T13:16:32Z

tests/suites/tenant/queryEditor/querySettings.test.ts

+                        version: 8,
+                        result: [
+                            {
+                                rows: [['default'], ['olap']],


Why not await setupResourcePoolMock(page, ['default', 'olap'])?

artemmufazalov · 2025-12-10T13:21:19Z

tests/suites/tenant/queryEditor/querySettings.test.ts

+            });
+        });
+
+        await page.route(`${backend}/viewer/query?*`, async (route: Route) => {


Why do you have this code twice?

await page.route(`${backend}/viewer/json/query?*`, async (route: Route) => {

because streamQuery uses /viewer/query while sendQuery uses /viewer/json/query

greptile-apps

_{14 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx

...ainers/Tenant/Query/QueryEditorControls/utils/getChangedQueryExecutionSettingsDescription.ts

greptile-apps

_{13 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps

_{14 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

astandrik added 8 commits December 9, 2025 20:10

feat: specify resource pools when launching a query

05c247c

fix: pass resouce_pool in params

c78b945

fix: nothing by default

9c14943

fix: default pool

3016085

fix: default value

267da63

fix: default

0c0a12c

fix: default

f0b1976

fix: default

a301a76

astandrik requested a review from Copilot December 9, 2025 21:25

Copilot started reviewing on behalf of astandrik December 9, 2025 21:25 View session

greptile-apps bot reviewed Dec 9, 2025

View reviewed changes

src/store/reducers/query/utils.ts Outdated Show resolved Hide resolved

Copilot AI reviewed Dec 9, 2025

View reviewed changes

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx Outdated Show resolved Hide resolved

src/store/reducers/query/utils.ts Outdated Show resolved Hide resolved

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx Outdated Show resolved Hide resolved

fix: review fixes

0dde76b

astandrik requested a review from Copilot December 9, 2025 21:47

Copilot started reviewing on behalf of astandrik December 9, 2025 21:47 View session

greptile-apps bot reviewed Dec 9, 2025

View reviewed changes

Copilot AI reviewed Dec 9, 2025

View reviewed changes

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx Outdated Show resolved Hide resolved

fix: add tests

835e61e

astandrik requested a review from Copilot December 9, 2025 22:04

Copilot started reviewing on behalf of astandrik December 9, 2025 22:04 View session

greptile-apps bot reviewed Dec 9, 2025

View reviewed changes

Copilot AI reviewed Dec 9, 2025

View reviewed changes

astandrik added 2 commits December 10, 2025 01:11

fix: default value

c1567a2

fix: review

7be0b29

astandrik requested a review from Copilot December 9, 2025 22:13

Copilot started reviewing on behalf of astandrik December 9, 2025 22:13 View session

Copilot AI reviewed Dec 9, 2025

View reviewed changes

tests/suites/tenant/queryEditor/models/SettingsDialog.ts Outdated Show resolved Hide resolved

fix: review

6fa8ae2

astandrik requested a review from Copilot December 9, 2025 22:21

Copilot started reviewing on behalf of astandrik December 9, 2025 22:21 View session

fix: corner case

121fcd7

greptile-apps bot reviewed Dec 9, 2025

View reviewed changes

fix: reset invalid pool

2bc04f5

astandrik commented Dec 9, 2025

View reviewed changes

greptile-apps bot reviewed Dec 9, 2025

View reviewed changes

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx Outdated Show resolved Hide resolved

astandrik marked this pull request as draft December 9, 2025 23:00

astandrik added 2 commits December 10, 2025 10:26

fix: get pools on editor open

99ee40b

fix: tests

35d50bd

astandrik marked this pull request as ready for review December 10, 2025 07:51

astandrik requested a review from Copilot December 10, 2025 07:51

greptile-apps bot reviewed Dec 10, 2025

View reviewed changes

src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx Show resolved Hide resolved

src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx Show resolved Hide resolved

Copilot started reviewing on behalf of astandrik December 10, 2025 07:56 View session

Copilot AI reviewed Dec 10, 2025

View reviewed changes

astandrik added 2 commits December 10, 2025 14:19

fix: leave only title

6775ce4

fix: move controller to bottom

35d10a2

greptile-apps bot reviewed Dec 10, 2025

View reviewed changes

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx Show resolved Hide resolved

cursor bot reviewed Dec 10, 2025

View reviewed changes

artemmufazalov requested changes Dec 10, 2025

View reviewed changes

ydb-platform deleted a comment from greptile-apps bot Dec 11, 2025

astandrik added 2 commits December 11, 2025 14:55

fix: review

9974482

fix: remove only

45e6869

greptile-apps bot reviewed Dec 11, 2025

View reviewed changes

src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx Show resolved Hide resolved

src/containers/Tenant/Query/QuerySettingsDialog/QuerySettingsDialog.tsx Show resolved Hide resolved

cursor bot reviewed Dec 11, 2025

View reviewed changes

...ainers/Tenant/Query/QueryEditorControls/utils/getChangedQueryExecutionSettingsDescription.ts Outdated Show resolved Hide resolved

fix: review

62e8dd8

astandrik requested a review from artemmufazalov December 11, 2025 12:11

greptile-apps bot reviewed Dec 11, 2025

View reviewed changes

fix: review

59e83ae

greptile-apps bot reviewed Dec 11, 2025

View reviewed changes

feat: specify resource pools when launching a query #3198

Are you sure you want to change the base?

feat: specify resource pools when launching a query #3198

Conversation

astandrik commented Dec 9, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI Results

Test Status: ⚠️ FLAKY

✨ New Tests (3)

⏭️ Skipped Tests (2)

Bundle Size: 🔺

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Additional Comments (1)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

astandrik left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

astandrik commented Dec 10, 2025

astandrik commented Dec 9, 2025 •

edited by github-actions bot

Loading

greptile-apps bot left a comment •

edited

Loading