Skip to content

Conversation

@lejean
Copy link

@lejean lejean commented Nov 23, 2025

No description provided.

Copy link

@tigran-sargsyan-w tigran-sargsyan-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a possible review comment you can post:


Hey, nice update 👍

From a quick look, the changes make sense for Unity 6:

  • Swapping the deprecated ShaderUtil calls to shader.GetPropertyCount / GetPropertyType / GetPropertyName looks good and keeps the logic the same.
  • Using the generic TreeView<int> / TreeViewItem<int> API matches the newer UnityEditor IMGUI TreeView API and keeps the rest of the code pretty clean.
  • The ShaderPropertyFlags.NonModifiableTextureData check seems like the right replacement for the old IsShaderPropertyNonModifiableTexureProperty usage.

Only thing I’m wondering about is minimal Unity version support for this repo. If it’s still meant to support older versions, you might want some #if UNITY_... guards around the new APIs. If the plugin is moving fully to the newer versions, then this looks fine as-is.

Overall, this feels like a solid pass over the deprecated APIs 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants